Re: nbd locking problems

From: Serge E. Hallyn
Date: Mon Jan 31 2011 - 14:34:41 EST

Quoting Serge E. Hallyn (serge@xxxxxxxxxx):
> Quoting Soren Hansen (soren@xxxxxxxxxxx):

(Sorry, I seem to have stupidly deleted later replies)

> As Dave just explained to me, BKL is released when you sleep :) I
> assume that's how it gets released around the kthread_create(). I
> *think* you're right that the new mutex is superfluous, but I'd like to
> look through the ioctl code and make sure there's no shared state which
> we need to protect. I don't see how there could be, or rather, if there
> were, then it was broken before.

Yup, removing nbd_mutex should be safe. Esp since the
bdev->bd_disk->private_data doesn't get changed outside
of nbd_init(). Removing it looks safe.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at