Re: [PATCH 1/7] sysdev: Do not register with sysdev when erroringon add
From: Borislav Petkov
Date: Mon Jan 31 2011 - 17:32:41 EST
On Mon, Jan 31, 2011 at 05:16:59PM -0500, Greg KH wrote:
> On Mon, Jan 24, 2011 at 04:28:57PM +0100, Borislav Petkov wrote:
> > From: Borislav Petkov <borislav.petkov@xxxxxxx>
> > When encountering an error while executing the driver's ->add method, we
> > should cancel registration and unwind what we've regged so far. The low
> > level ->add methods do return proper error codes but those aren't looked
> > at in sysdev_driver_register(). Fix that by sharing the unregistering
> > code.
> Have you actually hit this before? If so, where?
Sorta. I want to be paranoid when loading the microcode image file and
in patch 3/7 (http://marc.info/?l=linux-kernel&m=129588287409770) I
propagate the error in case loading the microcode fails. If we don't
cleanup here, the driver remains loaded and takes up resources. And if
you load it again, you get a sysfs warning about duplicated entries.
> > Also, fixup warning messages formatting while at it.
> Please, no, one patch per thing. Please break this up into two
> different patches.
Yes, will do.
> And, in the future, let me know that you need this for other work.
> Actually, why did you send this to Ingo in your pull request? What does
> your microcode patches need from this patch? It should go through my
> tree, especially as there is other sysdev work happening at the moment.
Sorry about that, I did not mean to bypass/offend you in any way.
> so, no, please don't send this on to anyone else right now.
Do you need the patches rediffed against a some tree of yours?
@Ingo: please disregard my pull request from today:
Guys, sorry again if I've caused any trouble.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/