Re: [PATCH 5/5] IPVS: Remove ip_vs_sync_cleanup from section __exit

From: Hans Schillstrom
Date: Tue Feb 01 2011 - 12:12:45 EST


>---- Original Message ----
>From: Simon Horman <horms@xxxxxxxxxxxx>
>To: netdev@xxxxxxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx
>Cc: "Randy Dunlap" <randy.dunlap@xxxxxxxxxx>, "Stephen Rothwell" <sfr@xxxxxxxxxxxxxxxx>, "Hans Schillstrom" <hans@xxxxxxxxxxxxxxx>, "Patrick McHardy" <kaber@xxxxxxxxx>, "Simon Horman" <horms@xxxxxxxxxxxx>
>Sent: Tue, Feb 1, 2011, 11:11 AM
>Subject: [PATCH 5/5] IPVS: Remove ip_vs_sync_cleanup from section __exit
>
>ip_vs_sync_cleanup() may be called from ip_vs_init() on error
>and thus needs to be accesible from section __init
>
>Reporte-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Signed-off-by: Hans Schillstrom <hans@xxxxxxxxxxxxxxx>
Tested-by: Hans Schillstrom <hans@xxxxxxxxxxxxxxx>

>---
> net/netfilter/ipvs/ip_vs_sync.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
>index d5a6e64..2a2a836 100644
>--- a/net/netfilter/ipvs/ip_vs_sync.c
>+++ b/net/netfilter/ipvs/ip_vs_sync.c
>@@ -1686,7 +1686,7 @@ int __init ip_vs_sync_init(void)
> return register_pernet_subsys(&ipvs_sync_ops);
> }
>
>-void __exit ip_vs_sync_cleanup(void)
>+void ip_vs_sync_cleanup(void)
> {
> unregister_pernet_subsys(&ipvs_sync_ops);
> }
>--
>1.7.2.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/