Re: [patch] memcg: remove impossible conditional when committing

From: KAMEZAWA Hiroyuki
Date: Thu Feb 03 2011 - 18:55:48 EST


On Thu, 3 Feb 2011 15:11:10 +0100
Johannes Weiner <hannes@xxxxxxxxxxx> wrote:

> No callsite ever passes a NULL pointer for a struct mem_cgroup * to
> the committing function. There is no need to check for it.
>
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>

But, could you add VM_BUG_ON(!mem) here ?

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/