Re: [PATCH -mmotm] staging/easycap: fix build when SND is notenabled

[Randy Dunlap]

On Sun, 6 Feb 2011 09:25:28 +0200 Tomas Winkler wrote:

> On Sat, Feb 5, 2011 at 7:36 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> >
> > Fix easycap build when CONFIG_SOUND is enabled but CONFIG_SND is
> > not enabled.
> >
> > These functions are only built when CONFIG_SND is enabled, so the
> > driver should depend on SND.
> > This means that having SND enabled is required for the (obsolete)
> > EASYCAP_OSS config option.
> 
> Actually SND enabled is needed when EASYCAP_OSS is NOT set.

I suspected that might be the case.

> I'm not sure, though how to force it in Kconfig,
> I didn't want to use choice ALSA, OSS as the OSS will be removed later.
> 
> Unfortunately I cannot do something like
> if EASYCAP_OSS == n
>     select SND
> endif

You can do
	select SND if !EASYCAP_OSS
but that may be too late or in the wrong location.

> I will try to come with proper fix

Thanks.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/