Re: [PATCH 3/4] olpc_dcon: move more variables into dcon_priv

From: Dan Carpenter
Date: Mon Feb 07 2011 - 01:31:11 EST


On Sun, Feb 06, 2011 at 03:28:46PM -0800, Andres Salomon wrote:
> bool mono:1;
> + bool asleep:1;
^^

Not needed.

> - return sprintf(buf, "%d\n", dcon_sleep_val);
> + struct dcon_priv *dcon = dev_get_drvdata(dev);
> + return sprintf(buf, "%d\n", dcon->asleep ? 1 : 0);
^^^^^^^

Also not needed.

These are fussy things. Feel free to fix them in a later patch series.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/