Re: [patch 07/10] m68knommu: Convert 5272 intc irq_chip to newfunctions

From: Thomas Gleixner
Date: Tue Feb 08 2011 - 04:49:34 EST


On Tue, 8 Feb 2011, Greg Ungerer wrote:
> > static void intc_external_irq(unsigned int irq, struct irq_desc *desc)
> > {
> > - desc->chip->ack(irq);
> > + get_irq_desc_chip(i)->irq_ack(desc->irq_data);
> ^^^ ^^^
> should this be:
>
> get_irq_desc_chip(desc)->irq_ack(&desc->irq_data)

Yes.

> I can't runtime test this right at the moment, but otherwise:
>
> Acked-by: Greg Ungerer <gerg@xxxxxxxxxxx>

Can you push that stuff linus wards for 39 or want me to do it ? It
has no dependencies whatsoever.

Thanks,

tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/