Re: [PATCH 02/26] x86-64, NUMA: Simplify hotplug node handling in acpi_numa_memory_affinity_init()

From: Tejun Heo
Date: Sat Feb 12 2011 - 12:57:01 EST


On Sat, Feb 12, 2011 at 6:47 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> -             if ((nd->start | nd->end) == 0)
>> -                     node_clear(node, nodes_parsed);
>
> after change
> looks like nodes_parsed is not set anymore for node that only have hotplug memory.

Yeap, which matches the above node_clear(). If the node was already
occupied, the bit would already be set. If not, the above
node_clear() would clear it, so the same result. The code was quite
convoluted.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/