Re: [PATCH 02/26] x86-64, NUMA: Simplify hotplug node handling inacpi_numa_memory_affinity_init()

[Yinghai Lu]

On 02/12/2011 09:56 AM, Tejun Heo wrote:
> On Sat, Feb 12, 2011 at 6:47 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>>> -             if ((nd->start | nd->end) == 0)
>>> -                     node_clear(node, nodes_parsed);
>>
>> after change
>> looks like nodes_parsed is not set anymore for node that only have hotplug memory.
> 
> Yeap, which matches the above node_clear().  If the node was already
> occupied, the bit would already be set.  If not, the above
> node_clear() would clear it, so the same result.  The code was quite
> convoluted.

no. if the node only have hotplug mem.
then nd->start and nd->end will be set to that hot plug range.
and old code does not clear nodes_parsed...

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/