Re: [PATCH] x86: fix section mismatch in reference fromnative_play_dead

From: Ingo Molnar
Date: Mon Feb 14 2011 - 07:26:15 EST



* Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> wrote:

> Fix
>
> WARNING: arch/x86/kernel/built-in.o(.text+0x19cde): Section mismatch in reference from
> the function native_play_dead() to the function .cpuinit.text:mwait_usable()
> The function native_play_dead() references the function __cpuinit mwait_usable().
>
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
>
> ---
>
> arch/x86/kernel/smpboot.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 0cbe8c0..0b8c6c9 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -1467,7 +1467,7 @@ static inline void hlt_play_dead(void)
> }
> }
>
> -void native_play_dead(void)
> +void __cpuinit native_play_dead(void)
> {
> play_dead_common();
> tboot_shutdown(TB_SHUTDOWN_WFS);

I think the right fix is Boris's fix below. Agreed?

Thanks,

Ingo