Re: [PATCH -next] PCI: fix tlan build when CONFIG_PCI is not enabled

[Sakari Ailus]

Sakari Ailus wrote:
> Randy Dunlap wrote:
> > From: Randy Dunlap<randy.dunlap@xxxxxxxxxx>
> >
> > When CONFIG_PCI is not enabled, tlan.c has a build error:
> > drivers/net/tlan.c:503: error: implicit declaration of function 'pci_wake_from_d3'
> >
> > so add an inline function stub for this function to pci.h when
> > PCI is not enabled, similar to other stubbed PCI functions.
> >
> > Signed-off-by: Randy Dunlap<randy.dunlap@xxxxxxxxxx>
> > Cc: Sakari Ailus<sakari.ailus@xxxxxx>
>
> Hi Randy,
>
> I think this issue in tlan driver was caused by my recent patch which
> added the suspend/resume support to tlan:
>
> <URL:http://marc.info/?l=linux-netdev&m=129564436110754&w=3>
>
> There apparently are tlan cards which are EISA (not PCI) which I forgot
> when writing the patch. The suspend/resume has been only tested with PCI
> as I have no EISA bus (let alone EISA tlan card!).

Right; so I suppose there's no PM support in EISA anyway. Other pci 
functions appear to be no-ops when CONFIG_PCI isn't defined so this 
patch seems right to me --- and no changes are needed in the tlan driver.

Acked-by: Sakari Ailus <sakari.ailus@xxxxxx>

--
Sakari Ailus
sakari.ailus@xxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/