Re: [PATCH v2] olpc_battery: convert to platform device

From: Dmitry Torokhov
Date: Wed Feb 16 2011 - 11:53:08 EST


On Wed, Feb 16, 2011 at 02:29:31PM +0000, Daniel Drake wrote:
>
> -static void __exit olpc_bat_exit(void)
> +static int __exit olpc_battery_remove(struct platform_device *pdev)
...
> + .remove = __devexit_p(olpc_battery_remove),

olpc_battery_remove should be annotated as __devexit. Sorry for not
noticing this before. Otherwise:

Reviewed-by: Dmitry Torokhov <dtor@xxxxxxx>

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/