Re: [PATCH] hwmon: (k10temp) add support for AMD Family 12h/14h CPUs

From: Jean Delvare
Date: Thu Feb 17 2011 - 14:23:31 EST


On Thu, 17 Feb 2011 10:39:34 -0800, Guenter Roeck wrote:
> On Thu, Feb 17, 2011 at 01:08:38PM -0500, Jean Delvare wrote:
> > On Thu, 17 Feb 2011 09:26:39 -0800, Guenter Roeck wrote:
> > > On Thu, Feb 17, 2011 at 03:22:40AM -0500, Clemens Ladisch wrote:
> > > > Add the PCI ID to support the internal temperature sensor of the
> > > > AMD "Llano" and "Brazos" processor families.
> > > >
> > > > Signed-off-by: Clemens Ladisch <clemens@xxxxxxxxxx>
> > >
> > > Applied, thanks.
> > >
> > > Since it meets the requirements for a stable patch, I applied it to the
> > > patch list for 2.6.38 and added Cc: stable@xxxxxxxxxxx
> >
> > Can we have a sensors-detect patch too?
> >
> Prepared that, but I am getting the following from the ddr3 patch.
>
> prog/detect/sensors-detect
> Useless use of private variable in void context at prog/detect/sensors-detect line 5287.
>
> Code is
> } elsif ($device_type => 9 && $device_type <= 11) {
>
> Should that be
> } elsif ($device_type >= 9 && $device_type <= 11) {
> instead ?

Yes, you're totally right.

> Odd, I didn't notice that before when I tried the ddr3 patch.

This is the part I modified from Clemens' original patch. What's really
odd is that I didn't notice the warning on my end. I see it now...
Sorry, I've just fixed it.

--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/