RE: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros

[John Linn]

> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd@xxxxxxxxxxxxxx]
> Sent: Thursday, February 17, 2011 2:58 PM
> To: Jamie Iles
> Cc: John Linn; linux@xxxxxxxxxxxxxxxx; arnd@xxxxxxxx;
catalin.marinas@xxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; glikely@xxxxxxxxxxxx;
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH V3 3/4] ARM: Xilinx: base header files and
assembly macros
> 
> On 02/17/2011 02:01 AM, Jamie Iles wrote:
> >> +
> >> +static void putc(char ch)
> >> +{
> >> +	/*
> >> +	 * Wait for room in the FIFO, then write the char into the FIFO
> >> +	 */
> >> +	while (UART_STATUS(LL_UART_PADDR) & UART_SR_TXFULL)
> >> +		;
> >
> > It might be worth adding a barrier() call to these loops to be
explicit
> > about the volatility.
> 
> I think you want cpu_relax() then.

Thanks Stephen.

> 
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.
> 


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/