Re: [PATCH v2 06/13] da850: pruss CAN board specific additions.

From: Subhasish Ghosh
Date: Fri Feb 18 2011 - 02:20:47 EST




--------------------------------------------------
From: "Sergei Shtylyov" <sshtylyov@xxxxxxxxxx>
Sent: Saturday, February 12, 2011 12:15 AM
To: "Subhasish Ghosh" <subhasish@xxxxxxxxxxxxxxxxxxxx>
Cc: <davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx>; <sachi@xxxxxxxxxxxxxxxxxxxx>; "Russell King" <linux@xxxxxxxxxxxxxxxx>; "Kevin Hilman" <khilman@xxxxxxxxxxxxxxxxxxx>; <nsekhar@xxxxxx>; "open list" <linux-kernel@xxxxxxxxxxxxxxx>; <m-watkins@xxxxxx>; <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 06/13] da850: pruss CAN board specific additions.

Subhasish Ghosh wrote:

This patch adds the pruss CAN pin mux and registers the device
with the pruss mfd driver.

Signed-off-by: Subhasish Ghosh <subhasish@xxxxxxxxxxxxxxxxxxxx>
[...]

diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
index 242d1ed..2ce5536 100644
--- a/arch/arm/mach-davinci/board-da850-evm.c
+++ b/arch/arm/mach-davinci/board-da850-evm.c
@@ -1053,8 +1053,43 @@ static __init int da850_evm_init_cpufreq(void)
[...]
static struct da8xx_pruss_devices pruss_devices[] = {
- {.dev_name = NULL,},
+ {
+ .dev_name = "da8xx_pruss_can",
+ .pdata = &can_data,
+ .pdata_size = sizeof(can_data),
+ .setup = da850_evm_setup_pruss_can,
+ },
+ {
+ .dev_name = NULL,
+ },

No need to explicitly initialize to NULL.

SG -- ok, Will remove

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/