Re: [tip:x86/trampoline] x86, reboot: Move the real-mode reboot codeto an assembly file

From: H. Peter Anvin
Date: Fri Feb 18 2011 - 12:42:19 EST


On 02/18/2011 04:31 AM, Brian Gerst wrote:
>> +
>> + /* Patch post-real-mode segment jump */
>> + movw dispatch_table(%ebx,%ecx,2),%cx
>> + movw %cx, 101f(%ebx)
>> + movw %ax, 102f(%ebx)
>
> This looks wrong. The type parameter is in %eax, not %ecx, and this
> code is expecting %eax to be a segment.
>

You're quite right. I decided to make a change, changed all the
invocations, and forgot to change the actual code. D'oh!

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/