Re: [PATCH 5/5] sched, autogroup: runtime enable/disable tuning fix

[Mike Galbraith]

On Sun, 2011-02-20 at 22:10 +0800, Yong Zhang wrote:
> On Sun, Feb 20, 2011 at 02:09:39PM +0100, Mike Galbraith wrote:
> > On Sun, 2011-02-20 at 15:08 +0800, Yong Zhang wrote:
> > > Now enable/disable autogroup at runtime is just a flag,
> > > it doesn't take effect on current process of the system.
> > 
> > Yup, they only move upon migration, which can take up to forever.
> 
> Yeah. so on UP, the user can have autogroup forever or not, and
> sched_autogroup_enable is a nop.

Yup, and that's the best argument for doing the active switch.

> Apart from runtime enable/disable issue, I think patch1~3 could
> still be applied beause they really fix some problem or bring
> some improvement.

Yeah.

Your whole series looked fine to me at a glance (sunday;), with the
exception of #2, that one is maybe iffy, depending on point of view.

It's iffy only in that the proc interface is there to show the group
(whether used or not, it's not about tasks really, just group), so the
user can easily twiddle it if he so desires, which has nada to do with
the group being active or not.

That said, I'd agree to whacking the proc interface wholesale in a
heartbeat.  It's really a wart.  If it were frequently used, it'd be
indicative of failure for the whole concept.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/