Re: [PATCH v2 18/21] ARM: tegra: cpufreq: Adjust memory frequencywith cpu frequency

[Olof Johansson]

On Sat, Feb 19, 2011 at 2:26 PM, Colin Cross <ccross@xxxxxxxxxxx> wrote:
> Signed-off-by: Colin Cross <ccross@xxxxxxxxxxx>

Patch description please. Besides that:

Acked-by: Olof Johansson <olof@xxxxxxxxx>

But note for future work:


> +       /*
> +        * Vote on memory bus frequency based on cpu frequency
> +        * This sets the minimum frequency, display or avp may request higher
> +        */
> +       if (rate >= 816000)
> +               clk_set_rate(emc_clk, 600000000); /* cpu 816 MHz, emc max */
> +       else if (rate >= 456000)
> +               clk_set_rate(emc_clk, 300000000); /* cpu 456 MHz, emc 150Mhz */
> +       else
> +               clk_set_rate(emc_clk, 100000000);  /* emc 50Mhz */
> +


This hardcodes frequencies that might or might not be used on some
systems and some parts. So it'll need to be revisited when enabling
other configurations.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/