Re: [PATCH v2 12/13] da850: pruss SUART platform specific additions.

From: Subhasish Ghosh
Date: Tue Feb 22 2011 - 08:23:12 EST


Ok, will do.

--------------------------------------------------
From: "Sergei Shtylyov" <sshtylyov@xxxxxxxxxx>
Sent: Tuesday, February 22, 2011 4:50 PM
To: "Subhasish Ghosh" <subhasish@xxxxxxxxxxxxxxxxxxxx>
Cc: <davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx>; <sachi@xxxxxxxxxxxxxxxxxxxx>; "Russell King" <linux@xxxxxxxxxxxxxxxx>; "Kevin Hilman" <khilman@xxxxxxxxxxxxxxxxxxx>; <nsekhar@xxxxxx>; "open list" <linux-kernel@xxxxxxxxxxxxxxx>; <m-watkins@xxxxxx>; <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 12/13] da850: pruss SUART platform specific additions.

Hello.

On 22-02-2011 12:18, Subhasish Ghosh wrote:

I could not follow your recommendations clearly, are you suggesting this:

int __init da8xx_register_pruss(struct da8xx_pruss_devices *pruss_device)
{
#ifdef CONFIG_SERIAL_PRUSS_SUART_MODULE
int ret;

ret = clk_add_alias(NULL, "da8xx_pruss_uart.1",
NULL, &da850_mcasp_device.dev);
if (ret < 0)
return ret;
#endif
da8xx_pruss_dev.dev.platform_data = pruss_device;
return platform_device_register(&da8xx_pruss_dev);
}

Yes. But still better would be to wrap clk_add_alias() into a function of its own (defining it empty if CONFIG_SERIAL_PRUSS_SUART_MODULE is not defined).

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/