Re: [rtc-linux] [PATCH 04/10] RTC: Cleanup rtc_class_ops->read_alarm()

From: Marcelo Roberto Jimenez
Date: Tue Feb 22 2011 - 16:27:00 EST


On Tue, Feb 22, 2011 at 16:58, john stultz <johnstul@xxxxxxxxxx> wrote:
> On Tue, 2011-02-22 at 19:51 +0000, Mark Brown wrote:
>> On Tue, Feb 22, 2011 at 11:35:10AM -0800, john stultz wrote:
>>
>> > Yea. The way I thought about it originally was that you can set an alarm
>> > and that alarm will fire if the machine is on, suspended or even in some
>> > cases off.  Then, when the machine is booted (system reset), the state
>> > of the RTC's alarm should not be trusted.
>>
>> > Your description of the AIE/UIE having random values aligns with that
>> > intuition.
>>
>> This seems rather worrying - it sounds like it might mean that the
>> device might come up firing spuriously which doesn't seem terribly
>> clever.
>
> Well, in those known cases the driver should initalize the irq modes to
> be off.

Just a correction to my post, it was not AIE/UIE with ramdom values,
it was an alarm or update interrupt pending bit in the status register
(RTSR) that woke up set after reboot, even before interrupts were
enabled. In this case, the device would wake up with an interrupt
pending. The interrupt routine would not clear an interrupt that was
not enabled and that lead to an infinite loop of interrupts.

Regards,
Marcelo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/