Re: [PATCH] tty: add TIOCVHANGUP: time for revoke() in f_ops ?

From: Alan Cox
Date: Tue Feb 22 2011 - 19:28:40 EST


> vhangup() is different from revoke(). vhangup() does weird SIGHUP
> handling and stuff, which I think goes way beyond what revoke() would
> eventually do. And that different behaviour becomes visible in various

Revoke() will also do this because you remove the controlling process
from the tty. What happens then is mandated by SuS/POSIX.

> > Its not a quick patch - that's why its not happened yet, vhangup(fd)
> > quickfix Lennart style is unfortunately a useless bodge job which like
> > most bodge jobs is simply going to spring leaks and need fixing again.
>
> Thanks. If you are trying to insult me, doesn't really work,

Not intended as an insult. Believe me I wish a fix like that was viable,
but it's not - which is why its not been in the tree for years.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/