Re: [PATCH 1/6] perf-events: Add support for supplementary eventregisters v5

[Lin Ming]

On Tue, 2011-02-22 at 23:20 +0800, Peter Zijlstra wrote:
> On Mon, 2011-02-21 at 00:56 +0800, Lin Ming wrote:
> > @@ -225,7 +225,10 @@ struct perf_event_attr {
> >         };
> >  
> >         __u32                   bp_type;
> > -       __u64                   bp_addr;
> > +       union {
> > +               __u64           bp_addr;
> > +               __u64           event_extra; /* Extra for some events */
> > +       };
> >         __u64                   bp_len;
> >  }; 
> 
> I did s/event_extra/config1/g and:
> 
> Index: linux-2.6/include/linux/perf_event.h
> ===================================================================
> --- linux-2.6.orig/include/linux/perf_event.h
> +++ linux-2.6/include/linux/perf_event.h
> @@ -227,9 +230,12 @@ struct perf_event_attr {
>  	__u32			bp_type;
>  	union {
>  		__u64		bp_addr;
> -		__u64		config1; /* Extra for some events */
> +		__u64		config1;	/* extension of config0 */
> +	};
> +	union {
> +		__u64		bp_len;
> +		__u64		config2;	/* extension of config1 */
>  	};
> -	__u64			bp_len;
>  };
>  
>  /*
> 
> Giving us basically 192 bits of config{,1,2} space and the possibility
> of eventually deprecating the bp_ stuff.

OK, 

Do you mean it's possible to encode bp_type/bp_addr/bp_len into
config1/config2?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/