Re: [PATCH v2 2/5] firmware: Basic dmi-sysfs support

From: Tony Luck
Date: Wed Feb 23 2011 - 14:46:08 EST


On Tue, Feb 22, 2011 at 5:53 PM, Mike Waychison <mikew@xxxxxxxxxx> wrote:
> +static void __init dmi_sysfs_register_handle(const struct dmi_header *dh,
> +                                            void *_ret)
> +{

I'm seeing some unaligned references from this function
on ia64. Code is loading a 2-byte value from an odd
address. We are dereferencing "dh", so looking at the
dmi_header definition, I'd have thought that we must
be touching dh->handle:

struct dmi_header {
u8 type;
u8 length;
u16 handle;
};

I don't see any code in this function that does this,
so I assume there is some inlining or macro stuff
happening.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/