Re: [PULL REQUEST] md and related patches for 2.6.38
From: Linus Torvalds
Date: Thu Feb 24 2011 - 01:02:50 EST
On Wed, Feb 23, 2011 at 9:53 PM, NeilBrown <neilb@xxxxxxx> wrote:
> The most noteworthy is :
> Fix over-zealous flush_disk when changing device size.
> which I include below in full.
Why did you do that butt-ugly "__invalidate_device2()"?
There are something like three users of that existing
__invalidate_device() function, it would have made for a smaller and
cleaner patch to just fix them all, rather than change the calling
convention, create that ugly "2" function, and add the wrapper
It's _doubly_ crazy, because that's exactly what you did to
"invalidate_inodes()", so it has this crazy mix of "change one
function" and "try to maintain another function unchanged".
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/