Re: [PATCH 07/12] n_tracerouter and n_tracesink additions.

[Alan Cox]

> > > +#define N_TRACESINK	23	/* Trace data routing for MIPI P1149.7 */
> > > +#define N_TRACEROUTER	24	/* Trace data routing for MIPI P1149.7 */
> > 
> > Two new ones?  Really?  Alan, no objection from you on this?
> 
> I'll let Alan chime in, but I did have Alan review this code before I
> submitted here.

There isn't really an elegant way of avoiding that. What probably does
want doing for a final merge is to make them more generic. So that
anything can be a source or a sink that meets a basic interface.

Then you'd be able to do

	set ldisc to tracesink
	ioctl (something or other) 		"attach to sink of
						 name 'modem/mipi/p1149.7'

or similar.

That would need a struct of some sort and a register_sink/unregister_sink
method. Ditto for tracerouter. Obviously for now only the current drivers
would support it but the interface is then there for anything else

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/