Re: [RFC 2/3] xhci: Fix cycle bit calculation during stallhandling.

From: Sarah Sharp
Date: Thu Feb 24 2011 - 10:39:16 EST

On Thu, Feb 24, 2011 at 02:18:24PM +0300, Sergei Shtylyov wrote:
> Hello.
> On 24-02-2011 5:31, Sarah Sharp wrote:
> >+ if (ep_ring->first_seg == ep_ring->first_seg->next&&
> >+ state->new_deq_ptr < dev->eps[ep_index].stopped_trb)
> >+ state->new_cycle_state ^= 0x1;
> The last line seems overindented.

Hi Sergei, doesn't complain about it. It is not a good use of my
time to respin this patch for one stylistic change that is not a
violation of the Kernel community norms.

I really feel strongly that you are wasting the community's time by
commenting on style when it is only a violation of your personal style,
without providing any useful feedback on the code itself.

I feel so strongly that I'm seriously considering setting up a feedback
bot for you. It would run any patch you reply to through,
and send you a small reminder when the patch passes, but you complained
about style. I think it would allow you to have a sense of how
frustrating it is to receive these unnecessary stylistic comments.

Sarah Sharp
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at