Re: [RFC PATCH] ipmi: convert OF driver to platform driver
From: Arnd Bergmann
Date: Fri Feb 25 2011 - 03:14:32 EST
On Thursday 24 February 2011, Grant Likely wrote:
> On Wed, Feb 23, 2011 at 03:37:59PM -0600, Rob Herring wrote:
> > From: Rob Herring <rob.herring@xxxxxxxxxxx>
> > of_bus is deprecated in favor of the plain platform bus. This patch
> > merges the ipmi OF driver with the existing platform driver.
> > CONFIG_PPC_OF occurrances are removed or replaced with CONFIG_OF.
> > Compile tested with and without CONFIG_OF. Tested OF probe and
> > default probe cases.
> > Signed-off-by: Rob Herring <rob.herring@xxxxxxxxxxx>
> Wow. That driver does some weird things with the driver model that
> really should be cleaned up. That said, this change looks correct.
> I'll add it to my tree and see how it goes.
Please keep me in the look when you want to do further into cleaning
this up. The OF code was initially done for the QS21 running SLOF, and
predates the flattened device tree specs.
I don't know if Christian still remembers the code, but it might
be worthwhile having him on Cc as well.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/