Re: [PATCH 2/2] debugfs: only allow root access to debugginginterfaces
From: Greg KH
Date: Fri Feb 25 2011 - 14:57:47 EST
On Tue, Feb 22, 2011 at 11:29:15PM +0300, Dan Carpenter wrote:
> On Tue, Feb 22, 2011 at 11:33:14AM -0800, Greg KH wrote:
> > Again, let's fix the real problems here, world-writable debugfs files.
> We could just ban them?
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index e7a7a2f..03ae095 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -223,6 +223,9 @@ struct dentry *debugfs_create_file(const char *name, mode_t mode,
> pr_debug("debugfs: creating file '%s'\n",name);
> + /* don't allow world writable files */
> + mode &= ~S_IWOTH;
> error = simple_pin_fs(&debug_fs_type, &debugfs_mount,
> if (error)
I have no objection to this patch, care to resend it with a
signed-off-by: so that I can apply it?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/