Re: [cpuops cmpxchg double V3 3/5] Generic support forthis_cpu_cmpxchg_double
From: Steven Rostedt
Date: Fri Feb 25 2011 - 15:53:50 EST
On Fri, 2011-02-25 at 14:44 -0600, Christoph Lameter wrote:
> On Fri, 25 Feb 2011, Steven Rostedt wrote:
> > > + VM_BUG_ON((unsigned long)(&pcp1) % (2 * sizeof(pcp1))); \
> > > + VM_BUG_ON((unsigned long)(&pcp2) != (unsigned long)(&pcp1) + sizeof(pcp1));\
> > > + VM_BUG_ON(sizeof(pcp1) != sizeof(pcp2)); \
> > Since this is a macro, and it looks like all these are constants (sizeof
> > and addresses), couldn't you just do a BUILD_BUG_ON() instead?
> The addresses are not constant.
I was thinking that if these are per_cpu then they would be global and
thus constant. But those are done at link time, which is too late.
OK, nevermind ;)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/