Re: [PATCH 3/3] x86,mm,64bit: Round up memory boundary forinit_memory_mapping_high()

From: Tejun Heo
Date: Sat Feb 26 2011 - 05:55:32 EST

On Sat, Feb 26, 2011 at 11:36:16AM +0100, Tejun Heo wrote:
> On Fri, Feb 25, 2011 at 07:08:40PM -0800, Yinghai Lu wrote:
> > + end_pfn = round_up(end_pfn, data->align>>PAGE_SHIFT);
> And now you're mapping beyond max_pfn without even noting the behavior
> change _anywhere_. What the hell? It's not like this point hasn't
> been brought up before. It has been mentioned _twice_ in this very
> thread. Come on.

Reading the code again, the range is capped by
mapping_work_data->start/end, so it won't go over max_pfn. I
apologize for the unwarranted rant about this part, but unfortunately
the rest of the complaints still stand.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at