Re: [PATCH 2/5] exec: introduce "bool compat" argument

From: Oleg Nesterov
Date: Sat Feb 26 2011 - 07:46:12 EST

On 02/25, Linus Torvalds wrote:
> On Fri, Feb 25, 2011 at 9:52 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> > No functional changes, preparation to simplify the review.
> I think this is wrong.
> If you introduce the "bool compat" thing, you should also change the
> type of the argument pointers to some opaque type at the same time.
> It's no longer really a
> const char __user *const __user *
> pointer at that point. Trying to claim it is, is just wrong. The type
> suddently becomes conditional on that 'compat' variable.

Yes, this is true.

And I agree this could be done in more clean way, just we need more
changed. Please see the next email.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at