Re: [PATCH v2] tpm_tis: Use timeouts returned from TPM

From: Stefan Berger
Date: Sat Feb 26 2011 - 09:03:57 EST

On 02/26/2011 08:49 AM, Jiri Slaby wrote:
On 02/26/2011 02:48 PM, Stefan Berger wrote:
On 02/26/2011 06:45 AM, Jiri Slaby wrote:
On 02/22/2011 08:41 PM, Stefan Berger wrote:
Below patch applies to the tip of the git tree.

- adjusting all timeouts for TPM devices reporting too low timeout
- also displaying in sysfs whether the timeouts are 'original' or

The current TPM TIS driver in git discards the timeout values returned
from the TPM. The check of the response packet needs to consider that
the return_code field is 0 on success and the size of the expected
packet is equivalent to the header size + u32 length indicator for the
TPM_GetCapability() result + 3 timeout indicators of type u32.

Since some TPMs seem to return timeouts in msec rather than usec,
I am now adjusting all the timeouts rather than just the one for short

I am also adding a sysfs entry 'timeouts' showing the timeouts that are
being used.
It works:
'It' means also 'suspend' works?

That's great! Thanks for testing the patch!



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at