Re: [PATCH 5/6] x86, NMI: Allow NMI reason io port (0x61) to beprocessed on any CPU

From: huang ying
Date: Sat Feb 26 2011 - 20:01:28 EST

On Sat, Feb 26, 2011 at 11:09 PM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
> On 02/26/2011 05:07 PM, huang ying wrote:
>> On Sat, Feb 26, 2011 at 8:34 PM, Cyrill Gorcunov<gorcunov@xxxxxxxxx>
>> Âwrote:
>> [snip]
>>>> Why? ÂWithout LVT reconfig, system with this patch can not work
>>>> properly?
>>> ÂI guess we have a few nits here -- first an important comment were
>>> removed which doesn't reflect what happens on hw level for real. At
>>> least we should put it back just to not confuse people who read this
>>> code, something like
>>> Â Â Â Â/*
>>> Â Â Â Â * FIXME: Only BSP can see external NMI for now and hot-unplug
>>> Â Â Â Â * for BSP is not yet implemented
>>> Â Â Â Â */
>>> Â Â Â ÂWARN_ON_ONCE(smp_processor_id());
>>> ÂThe reason for WARN_ON_ONCE here is that -- imagine the situation when
>>> perf-nmi happens on one cpu with external nmi on BSP and for some reason
>>> (say code on upper level is screwed\bogus or anything else) nmi-notifier
>>> didn't handled it properly as result we might have a report like "SERR
>>> for
>>> reason xx on CPU 1" while this cpu didn't see this signal at all. And
>>> then
>>> due to locking ordering BSP will see unknown nmi while in real those nmi
>>> belongs
>>> him and it was CPU 1 who observed erronious NMI from upper level. Note
>>> this
>>> is theoretical scenario I never saw anything like this ;)
>> Yes. ÂThat is possible, at least in theory. ÂBut similar issue is
>> possible for original code too. ÂFor example, On CPU 0,
>> 1. perf NMI 1 triggered
>> 2. NMI handler enter
>> 3. perf NMI 2 triggered (1 NMI is pending)
>> 4. perf NMI handler handled 2 events
>> 5. NMI handler return
>> 6. NMI handler enter (because of pending NMI)
>> 7. external NMI triggered (another NMI is pending)
>> 8. external NMI handler handled SERR
>> 9. NMI handler return
>> 10. NMI handler enter (because of pending NMI)
>> 11. unknown NMI triggered
>> If my analysis is correct, this kind of issue can not be resolved even
>> if we revert to original code.
>> Best Regards,
>> Huang Ying
> ÂOf course there is a way to hit unknown nmi if upper level is screwed (we
> may see this with p4
> pmu on ht machine+kgdb which I didn't manage to fix yet) but with the former
> code an external nmi would
> not ever be handled by cpu which apic is not configured as a listener
> regardless anything. Ie there was 1:1
> mapping between extnmi observer and handler.
> ÂProbably we should put question in another fashion, ie in the fasion of
> overall design -- who should be
> responsible for handling external nmis, 1) the cpu which apic is configured
> to observe such nmis or 2) any cpu?
> If we take 1) then no lock is needed and underlied code will report real cpu
> number who observed nmi. If
> we take 2) then lock is needed but we need a big comment in default_do_nmi
> together with probably cpu number
> fixed in serr\iochk printk's.

I am OK with both solutions.

Best Regards,
Huang Ying
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at