Re: [PATCH 2/2] x86,mm,64bit: Round up memory boundary forinit_memory_mapping_high()
From: Ingo Molnar
Date: Sun Feb 27 2011 - 06:54:26 EST
* Tejun Heo <tj@xxxxxxxxxx> wrote:
> > will have problem with cross node conf. like 0-4g, 8-12g on node0, 4g-8g,
> > 12g-16g on node1.
> And how common are they? This whole cruft is basically meaningless if 1GiB
> mapping is supported, IOW, basically on all AMD 64s and all post-nehalem intels.
> Why not just cite the limitation in the comment and stick to something simple?
Such complexity should be justified via very careful "perf stat --repeat"
I.e. showing 'before patch' and 'after patch' instruction, TLB miss and cycle
counts, showing that a positive effect that goes beyond the noise of the measurement
1GB mappings should be assumed as the common case - anything else probably does not
matter from a future performance/scalability POV. For vmalloc() it might make sense
- but even for those precise measurements should be done about the positive effect.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/