Re: [PATCH 1/2] HID: ntrig don't dereference unclaimed hidinput
From: Peter Hutterer
Date: Sun Feb 27 2011 - 17:34:57 EST
On Sat, Feb 26, 2011 at 02:50:06AM -0500, Rafi Rubin wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> On 02/26/11 02:36, Henrik Rydberg wrote:
> > Hi Rafi,
> > On Fri, Feb 25, 2011 at 12:15:31AM -0500, Rafi Rubin wrote:
> >> Moved the claimed input check before dereferencing field->hidinput to
> >> fix a reported invalid deference bug.
> > How long has this problem been seen? If it is recent, it should
> > perhaps be fixed in the hid core instead. If it turns out to be an old
> > problem, please add stable to the Cc.
> I have no idea. Peter discovered it with a preproduction unit. He sent me a
> proposed fix which seemed quite sensible. I have not seen the bug in action nor
> records of the traffic.
Ben tried to get some nouveau fixes in for a new box that box crashed on
bootup. v2.6.38-rc5-115-g6f576d5 is the version I tried but I can't say when
either way, given that the same fix is in at least one more driver it would
make sense fixing this ealier in the stack.
> >> Switched to a goto instead of an extra indent for most of the function.
> > If you put these janitory changes into a separate patch, it will be
> > much easier to apply the bugfix to stable versions.
> > Thanks,
> > Henrik
> It might be a few days, but I'll split that into two patches when I get a chance.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
> -----END PGP SIGNATURE-----
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/