Re: [PATCH] memcg: clean up migration
From: Minchan Kim
Date: Sun Feb 27 2011 - 18:38:58 EST
On Mon, Feb 28, 2011 at 6:09 AM, Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
> On Mon, Feb 28, 2011 at 12:49:25AM +0900, Minchan Kim wrote:
>> This patch cleans up unncessary BUG_ON check and confusing
>> charge variable.
>> That's because memcg charge/uncharge could be handled by
>> mem_cgroup_[prepare/end] migration itself so charge local variable
>> in unmap_and_move lost the role since we introduced 01b1ae63c2.
>> And mem_cgroup_prepare_migratio return 0 if only it is successful.
>> Otherwise, it jumps to unlock label to clean up so BUG_ON(charge)
>> isn;t meaningless.
>> Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
>> Cc: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>
>> Cc: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>
>> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
>> Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx>
> Reviewed-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Thanks, Minchan!
> Â Â Â ÂHannes
> PS: Btw, people sometimes refer to commits by hashes from trees other
> than Linus's, so it's nice to include the subject as well:
> Â Â Â Â01b1ae6 memcg: simple migration handling
> You get this easily by taking the first line of
> Â Â Â Âgit show --oneline <commithash>
> though there are probably other ways.
I forgot adding the name with old comment's copy & paste. I will
resend with fixing some typo.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/