Hello Linus,I propose to refactor your patchset, moving from procfs to sysfs.
On Tue, Feb 15, 2011 at 01:58:00PM +0100, ext Linus Walleij wrote:2010/5/11 Eduardo Valentin<eduardo.valentin@xxxxxxxxx>:Got forgotten :-(. Unfortunately I didn't pushed it hard enough.
Here is the version 5 of the change to export OMAP data to userspaceEduardo, what has happened to this patchset?
(name, revision, id code, production id and die id).
Basically, this version is still attempting to create a new file under /proc.
It is the /proc/socinfo, which should be used to export bits which are SoC specific
(not CPU related, nor machine related).
So, differences between previous version are:
- merged patch 02/04 with 03/04 to avoid compilation breakages.
- simplified the seq_file usage by using the single_open and single_release functions
- exported a function to register a seq_operation .show callback
- adapted the changes accordingly
As usual, comments are welcome.
About the location of this new sysfs entry, where do you think it should be?Do you want help in picking it up and try to polish it up?Yeah, but it would need a refactoring. IIRC, result of last discussion was that
we should not mess with /proc. So, maybe moving back to something under sysfs.
Perhaps /sys/devices/soc or so?