Re: [PATCH] Staging: keucr: Remove all type defines
From: Dan Carpenter
Date: Tue Mar 01 2011 - 15:00:31 EST
On Tue, Mar 01, 2011 at 08:29:50PM +0100, Roel Van Nyen wrote:
> Remove all type defines from driver and replace them with kernel built-in types.
>
> Signed-off-by: Roel Van Nyen <roel.vannyen@xxxxxxxxx>
Some of your other patches were merged so this doesn't apply to
linux-next any more.
> -typedef u8 BOOLEAN;
It might be better to use bool type or int for boolean variables. But
that can't be done automatically, it has to be audited carefully. I
don't feel strongly about this, I'm just throwing it out there as food
for thought. You are using the remove-typedef program btw?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/