Re: [tip:x86/mm] x86: Work around old gas bug

[Ingo Molnar]

* Jan Beulich <JBeulich@xxxxxxxxxx> wrote:

> >>> On 02.03.11 at 09:42, tip-bot for Shaohua Li <shaohua.li@xxxxxxxxx> wrote:
> > Commit-ID:  253d89d3dd6b65595f317e5f1ecef43aa207a3a0
> > Gitweb:     
> > http://git.kernel.org/tip/253d89d3dd6b65595f317e5f1ecef43aa207a3a0 
> > Author:     Shaohua Li <shaohua.li@xxxxxxxxx>
> > AuthorDate: Tue, 1 Mar 2011 15:52:26 -0800
> > Committer:  Ingo Molnar <mingo@xxxxxxx>
> > CommitDate: Wed, 2 Mar 2011 08:16:23 +0100
> > 
> > x86: Work around old gas bug
> > 
> > pre-2.16 binutils works fine, post-2.16 binutils works fine, but 2.16 broke 
> > again:
> > 
> >  > arch/x86/kernel/entry_64.S: Assembler messages:
> >  > arch/x86/kernel/entry_64.S:984: Error: junk at end of line, first 
> > unrecognized character is `1'
> >  > [...]
> > 
> > Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxxxx>
> > LKML-Reference: <201103012352.p21NqRN1006974@xxxxxxxxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> 
> Ingo, didn't you write yesterday that this looks unacceptable to you?

Yes, and we can push this to Linus only once that's been resolved. I trust you to 
queue up the real solution or come up with good reasons why that is not possible for 
GAS 2.16. (at which point we'll just have to live with the ugliness, up to the point 
we decide to deprecate binutils 2.16.)

Meanwhile, what i hate more than ugly code repetition is code that does not build at 
all on akpm's test environment ;-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/