Re: [PATCH v2 1/4] perf-events: Add support for supplementary event registers

[Stephane Eranian]

On Wed, Mar 2, 2011 at 11:34 AM, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:
> On Wed, 2011-03-02 at 08:48 +0100, Stephane Eranian wrote:
>> >> > Â Â Â Â__u32 Â Â Â Â Â Â Â Â Â bp_type;
>> >> > - Â Â Â __u64 Â Â Â Â Â Â Â Â Â bp_addr;
>> >> > - Â Â Â __u64 Â Â Â Â Â Â Â Â Â bp_len;
>> >> > + Â Â Â union {
>> >> > + Â Â Â Â Â Â Â __u64 Â Â Â Â Â bp_addr;
>> >> > + Â Â Â Â Â Â Â __u64 Â Â Â Â Â config1; /* extension of config0 */
>> >> > + Â Â Â };
>> >> > + Â Â Â union {
>> >> > + Â Â Â Â Â Â Â __u64 Â Â Â Â Â bp_len;
>> >> > + Â Â Â Â Â Â Â __u64 Â Â Â Â Â config2; /* extension of config1 */
>> >> > + Â Â Â };
>> >> > Â};
>> >> >
>> >> I don't see where those config0 or config1 are coming from.
>> >
>> > config0 means perf_event_attr::config.
>> >
>> yes.
>>
>> > Peter suggested to extend the attr config space.
>> > http://marc.info/?l=linux-kernel&m=129838808907525&w=2
>> >
>> Ok, I get it, it is cascading. that's fine.
>
> I initially put config and config0 in a union, but that made compilation
> fail and fixing that up vs the benefit of actually having a config0,
> which seemed near 0, led me to drop that part. Forgot to update the
> comment though ;-)
>
Ok, but that's not committed yet, isn't it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/