Re: perf archive warning

[Han Pingtian]

On Thu, Mar 03, 2011 at 08:38:25AM +0800, Lin Ming wrote:
> On Wed, 2011-03-02 at 16:53 +0800, Han Pingtian wrote:
> > On Wed, Mar 02, 2011 at 04:29:41PM +0800, Lin Ming wrote:
> > > > 
> > > > root@intel-s3e36-01 perf]# ./perf-archive
> > > > tar: .build-id/b2/370e39ea2898c6e11c188e2f3879e4e3d6d1ef: Cannot stat:
> > > > No such file or directory
> > > > tar: .build-id/b2/370e39ea2898c6e11c188e2f3879e4e3d6d1ef: Cannot stat:
> > > > No such file or directory
> > > > tar: Exiting with failure status due to previous errors
> > > 
> > > kernel.kallsyms is not created successfully in the buildid-cache.
> > > Could you have a try below patch?
> > > 
> > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> > > index 72c124d..d3b5062 100644
> > > --- a/tools/perf/util/header.c
> > > +++ b/tools/perf/util/header.c
> > > @@ -271,11 +271,16 @@ int build_id_cache__add_s(const char *sbuild_id, const char *debugdir,
> > >  			  const char *name, bool is_kallsyms)
> > >  {
> > >  	const size_t size = PATH_MAX;
> > > -	char *realname = realpath(name, NULL),
> > > +	char *realname,
> > >  	     *filename = malloc(size),
> > >  	     *linkname = malloc(size), *targetname;
> > >  	int len, err = -1;
> > >  
> > > +	if (is_kallsyms)
> > > +		realname = (char *)name;
> > > +	else
> > > +		realname = realpath(name, NULL);
> > > +
> > >  	if (realname == NULL || filename == NULL || linkname == NULL)
> > >  		goto out_free;
> > >  
> > > @@ -307,7 +312,8 @@ int build_id_cache__add_s(const char *sbuild_id, const char *debugdir,
> > >  	if (symlink(targetname, linkname) == 0)
> > >  		err = 0;
> > >  out_free:
> > > -	free(realname);
> > > +	if (!is_kallsyms)
> > > +		free(realname);
> > >  	free(filename);
> > >  	free(linkname);
> > >  	return err;
> > > 
> > The patch didn't fix this problem. 
> 
> Did you re-run perf command?
> Need to re-run it to generate kernel.kallsyms build-id cache.
> 
> For example, 
> 
> $ perf record -- sleep 3
> $ perf-archive
I think I must do something wrong yesterday when testing your patch. It
works just fine today, the problem has been fixed by it. Thanks! 
> 
> If the problem is still there, please attach below output:
> 
> $ tree ~/.debug
> 
> Thanks,
> Lin Ming
> 
> > > 
> > > > Now please run:
> > > > 
> > > > $ tar xvf perf.data.tar.bz2 -C ~/.debug
> > > > 
> > > > wherever you need to run 'perf report' on.
> > > > [root@intel-s3e36-01 perf]# ./perf --version
> > > > perf version 2.6.38.rc6.166.g493f33
> > > > [root@intel-s3e36-01 perf]# ./perf buildid-list
> > > > b2370e39ea2898c6e11c188e2f3879e4e3d6d1ef [kernel.kallsyms]
> > > > dd95cb496ebc4ed922eeb5640965f1243fcfcd9a
> > > > /lib/modules/2.6.32-118.el6.x86_64/kernel/fs/ext4/ext4.ko
> > > > 9e1aca88b83308cec7574d74975fa6f7d654c96e /lib64/libc-2.12.so
> > > > d880be15bf992b5fbcc629e6bbf1c747a928ddd5 /lib64/libglib-2.0.so.0.2200.5
> > > > d1b2ca4e1ec8f81ba820e5f1375d960107ac7e50 /usr/lib64/libstdc++.so.6.0.13
> > > > [root@intel-s3e36-01 perf]#
> > > > 
> > > > --
> > > > Han Pingtian
> > > > Quality Engineer
> > > > hpt @ #kernel-qe
> > > > Red Hat, Inc
> > > > Freedom ... courage ... Commitment ... ACCOUNTABILITY
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > > > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > > Please read the FAQ at  http://www.tux.org/lkml/
> > > 
> > 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Han Pingtian
Quality Engineer
hpt @ #kernel-qe
Red Hat, Inc
Freedom ... courage ... Commitment ... ACCOUNTABILITY
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/