Re: [patch] Fix bug #13853: dereference pointer 'dev' before nullcheck

From: Randy Dunlap
Date: Thu Mar 03 2011 - 11:41:32 EST


On Thu, 3 Mar 2011 09:11:56 +0100 Wolfram Sang wrote:

> Hi,
>
> > Don't ever mention "bug #13853", because this number makes no sense
> > for everyone except you. A proper subject may be:
> >
> > [PATCH] ariadne: fix possible null dereference.
>
> I agree for the subject line. Still, in the body or maybe after the "---" I'd
> think it makes sense, so it is known there is a bugzilla entry to close? Also,
> using search engines, one will be able to dig up the patch.

It should just refer to the full bugzilla #13853 URL:
https://bugzilla.kernel.org/show_bug.cgi?id=13853

> > And please send your patches to proper maintainers and mailing list,
> > David Miller and netdev@xxxxxxxxxxxxxxx in particular.
>
> Yup. Using scripts/get_maintainers.pl is the way to go here.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/