Re: Re: changing EXPORT_SYMBOL_GPL to EXPORT_SYMBOL in DD-WRT
From: Christian Scheele
Date: Thu Mar 03 2011 - 13:26:34 EST
Hi alltogether,
http://svn.dd-wrt.com:8000/changeset/16371
http://svn.dd-wrt.com:8000/changeset/16372
we discussed this internally and found a solution that does not need
this change anymore.
The problematic code did not end up in any distributed binary.
Thanks for bringing this issue to our attention.
If you have any further comments or question, please don't hesitate to
contact me.
--
Mit freundlichen Grüssen / Regards
Christian Scheele
NewMedia-NET GmbH
Firmensitz: Berliner Ring 101, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.newmedia-net.de / http://www.dd-wrt.com
email: scheele@xxxxxxxxxxxxxxx
Tel.: +496251-582650 / Fax: +496251-5826565
On 22.07.64 20:59, Sebastian Gottschall (DD-WRT) wrote:
The Problem source is easy. i migrated a new compiler which is Linaro
4.5.2 and this compiler inlines various function which have been not
inlined in my previous compiler which was 4.3.3
so i was running into this symbol problems newly today with the Atheros
802.11n LSDK Driver.
For example. the symbol init_uts_ns is declared as GPL only. originally
a function was used which returned this symbol. this worked in the past.
but since this function is marked as inline, the symbol is now directly
compiled into
the driver which raised a compile problem.
we are also migrating to ath9k in background, but we still need to
develop alot of features to ath9k until we can use it as our current
modified LSDK driver.
so i needed to work around this problem today, to keep everything
working in my sourcetree
i hope you understand the problem in my side. it would remain just as
temporarily solution until i fixed that problem in another way.
for the init_uts_ns problem there is a solution right now. but for the
crypto api i'm still looking for. normally i can avoid this by removing
the soft crypto code which isnt used by newer hardware
but for backward compatiblity with older chipsets, they need to remain
regards,
Sebastian Gottschall
Am 03.03.2011 16:23, schrieb Harald Welte:
Hi Sebastian, Armijn and others,
I can only follow what Armijn has been writing.
On Thu, Mar 03, 2011 at 03:55:59PM +0100, Armijn Hemel wrote:
I noticed that a few hours ago you changed a few lines in the kernel
source of DD-WRT, changing the export from a few symbols from 'GPL only'
to something a lot more permissive:
While the ideas and thoughts regarding the legal implications of
EXPORT_SYMBOL_GPL are wide (see e.g.http://lwn.net/Articles/154602/) and there
is no precedent as far as I know, there seems general consensus that it _at
least_ signifies the explicit intent of the author.
By using the _GPL variant, the author unmistakingly indicates:
"I consider any use of that symbol to create a derivative work which must again
be licensed under GNU GPL"
So by modifying a _GPL symbol into the non-GPL variant (and using the code from
a non-GPL module), one would clearly violate the intent of the original author.
Whether or not that intent of the author is grounded in copyright law may
depend on the specific jurisdiction, circumstances and the judge that would
make up his mind about it, if such a case ever went to court.
I would be interested to hear what DaveM, James Morris and Herbert Xu
as the authors of the files in question have to say about such activity.
Regards,
Harald
--
Mit freundlichen Grüssen / Regards
Sebastian Gottschall / CTO
NewMedia-NET GmbH - DD-WRT
Firmensitz: Berliner Ring 101, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email:s.gottschall@xxxxxxxxxx
Tel.: +496251-582650 / Fax: +496251-5826565
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/