Re: [git pull] i_nlink fixes, part 1

[Linus Torvalds]

Al, you _really_ need to improve your chagelogs.

On Wed, Mar 2, 2011 at 10:32 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> Al Viro (8):
>      sysv: i_nlink races in rename()\
>      ufs: i_nlink races in rename()
>      minix: i_nlink races in rename()
>      nilfs2: i_nlink races in rename()
>      exofs: i_nlink races in rename()

What _are_ the races? You don't explain. And the patch in no way makes
it obvious either.

Now, compare it to the explanation for the ext2 case in commit
e8a80c6f769d and ask yourself: why didn't you? Yes, I can read _that_
commit, and I know what's going on, but a few weeks from now (or for
anybody else that only reads the commits for the one filesystem they
care about), that single line is going to be totally useless.

Maybe it doesn't need to be as extensive, but dang it, it needs to be
more than "fix races" with no explanation at all.

Saying just "fix race" may be fine if the patch itself is totally
self-explanatory (add a missing lock or whatever), but even then I'd
prefer something more.

I realize that you are really used to RCS, which made it a pain to
write any kind of explanation at all, but come on.

                        Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/