Re: [PATCH 05/10] block: remove per-queue plugging

[Jens Axboe]

On 2011-03-04 14:02, Shaohua Li wrote:
> 2011/3/4 Mike Snitzer <snitzer@xxxxxxxxxx>:
>> I'm now hitting a lockdep issue, while running a 'for-2.6.39/stack-plug'
>> kernel, when I try an fsync heavy workload to a request-based mpath
>> device (the kernel ultimately goes down in flames, I've yet to look at
>> the crashdump I took)
>>
>>
>> =======================================================
>> [ INFO: possible circular locking dependency detected ]
>> 2.6.38-rc6-snitm+ #2
>> -------------------------------------------------------
>> ffsb/3110 is trying to acquire lock:
>>  (&(&q->__queue_lock)->rlock){..-...}, at: [<ffffffff811b4c4d>] flush_plug_list+0xbc/0x135
>>
>> but task is already holding lock:
>>  (&rq->lock){-.-.-.}, at: [<ffffffff8137132f>] schedule+0x16a/0x725
>>
>> which lock already depends on the new lock.
> I hit this too. Can you check if attached debug patch fixes it?

I'll take a look at this. It would be really nice if we could move the
plug flush outside of the runqueue lock.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/