Re: [PATCH 6/10] KVM: MMU: don not record gfn in kvm_mmu_pte_write

From: Avi Kivity
Date: Sun Mar 06 2011 - 07:16:50 EST


On 03/06/2011 02:14 PM, Avi Kivity wrote:
On 03/04/2011 01:00 PM, Xiao Guangrong wrote:
No need to record the gfn to verifier the pte has the same mode as
current vcpu, it's because we only speculatively update the pte only
if the pte and vcpu have the same mode

True. We can, as an additional cleanup, change mmu_pte_write_new_pte() to just do vcpu->arch.mmu.update_pte(...) instead of the if ().


Also, we can remove the pfn guessing and to it in FNAME(update_pte), using gfn_to_pfn_atomic().

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/