RE: [PATCH] ARM: twd: Adjust localtimer frequency withcpufreqnotifiers

[Santosh Shilimkar]

> -----Original Message-----
> From: linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:linux-
> arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Linus Walleij
> Sent: Sunday, March 06, 2011 5:37 PM
> To: Santosh Shilimkar
> Cc: Russell King; Srinidhi KASAGAR; Harald Gustafsson; Linus
> Walleij; linux-kernel@xxxxxxxxxxxxxxx; Rickard ANDERSSON; martin
> persson; Colin Cross; Varun Swara; Catalin Marinas; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] ARM: twd: Adjust localtimer frequency
> withcpufreqnotifiers
>
> On Sat, Mar 5, 2011 at 9:19 AM, Santosh Shilimkar
> <santosh.shilimkar@xxxxxx> wrote:
>
> > While doing this patch for OMAP I also found that
> > CPUFREQ notifiers does delays scaling timer frequency
> > and there is a tick deviation(3-4 ms) around 1st tick and
> > last tick around twd rescaling.
>
> Is this caused by ticks that have been programmed
> already (based on the previous frequency) when the scaling
> takes effect? (That's most likely I think.)
>
That's correct Linus. I noticed that Collin's patch reduces that
problem a bit. In my patch I was always leaving the scaling
to post notifier which actually aggravates the scenario.

> The latter could be fixed by simply calling
> schedule() for each CPU connected in the same core as
> the TWD at the end of twd_update_cpu_frequency(),
> couldn't it?
>
I don't think schedule will do any difference here because
it's the actual tick duration which getting changed. The
tick does happen as per the timer load value. Now it all
depends at what point time in tick window the timer scaling
happens.

> Colin what do you say?
>
> > Another issue was not able to select higher fixed twd rate
> > and found fix for the same.
>
> Can you send out the patch?
>
Sure. May be let's get all these twd scaling
patches on the list. Rob's clock patches, Collin's
notifier patch. And then I shall post the fix on
top of that.

Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/