Re: [PATCH] FC: cifs: Initialized an uninitialized variable

[Steve French]

On Mon, Mar 7, 2011 at 10:26 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Mar 07, 2011 at 08:00:09PM -0800, Vinay Sawal wrote:
>> Removed a compile time warning by initializing an uninitialized variable.
>
>> -     int rc;
>> +     int rc = -EFAULT;
>
> Why is that the right thing to do?  Other than "it made the compiler to
> STFU, therefore it is Good(tm)", please.

Hard to disagree with Al's logic, although changing the scope of rc to
within the for loop might also make both your compiler happy and more
sense.   In any case, I prefer real bug fixes.


-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/