Re: [PATCH v3] misc: adds support the FSA9480 USB Switch

From: Dave Jones
Date: Tue Mar 08 2011 - 16:03:01 EST


On Tue, Mar 08, 2011 at 03:56:56PM +0900, Minkyu Kang wrote:

> +static DEVICE_ATTR(switch, S_IRUGO | S_IWUGO,
> + fsa9480_show_manualsw, fsa9480_set_manualsw);

This probably shouldn't be world writable if it's writing to hardware.

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/