Re: [PATCH 05/10] block: remove per-queue plugging

From: Jeff Moyer
Date: Tue Mar 08 2011 - 16:37:05 EST


Jens Axboe <jaxboe@xxxxxxxxxxxx> writes:

> On 2011-03-08 21:21, Mike Snitzer wrote:
>> On Tue, Mar 08 2011 at 7:16am -0500,
>> Jens Axboe <jaxboe@xxxxxxxxxxxx> wrote:
>>
>>> On 2011-03-03 23:13, Mike Snitzer wrote:
>>>> I'm now hitting a lockdep issue, while running a 'for-2.6.39/stack-plug'
>>>> kernel, when I try an fsync heavy workload to a request-based mpath
>>>> device (the kernel ultimately goes down in flames, I've yet to look at
>>>> the crashdump I took)
>>>
>>> Mike, can you re-run with the current stack-plug branch? I've fixed the
>>> !CONFIG_BLOCK and rebase issues, and also added a change for this flush
>>> on schedule event. It's run outside of the runqueue lock now, so
>>> hopefully that should solve this one.
>>
>> Works for me, thanks.
>
> Super, thanks! Out of curiousity, did you use dm/md?

mm/memory-failure.c: In function 'hwpoison_user_mappings':
mm/memory-failure.c:948: error: implicit declaration of function 'lock_page_nosync'

You missed a conversion of lock_page_nosync -> lock_page.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/